Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the project for Xcode 11.1 #438

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Update the project for Xcode 11.1 #438

merged 1 commit into from
Nov 5, 2019

Conversation

Vkt0r
Copy link
Member

@Vkt0r Vkt0r commented Nov 5, 2019 •
edited
Loading

  • Update the Gemfile dependencies.
  • Update the Xcode version in the config.yml file.

@swifter-bot
Copy link

swifter-bot commented Nov 5, 2019 •
edited
Loading

2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @Vkt0r 👋.

Generated by 🚫 Danger

@Vkt0r
Update the project for Xcode 11.1
6a56f98 
* Update the `Gemfile` dependencies
* Update the Xcode version in the `config.yml` file
@Vkt0r Vkt0r marked this pull request as ready for review November 5, 2019 04:38
pvzig
pvzig approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@pvzig pvzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vkt0r Vkt0r merged commit 74d111d into httpswift:stable Nov 5, 2019
@Vkt0r
Copy link
Member Author

Vkt0r commented Nov 5, 2019

Thanks @pvzig!

@Vkt0r Vkt0r deleted the danger-fix branch November 5, 2019 16:29
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#438 from Vkt0r/danger-fix
cc64c3c 
Update the project for Xcode 11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvzig pvzig pvzig approved these changes

@adamkaplan adamkaplan Awaiting requested review from adamkaplan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vkt0r @swifter-bot @pvzig