RFC 6265bis: Specify handling of CTL characters in set-cookie-string #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlily1
force-pushed
the
6265bis-set-cookie-ctl
branch
from
10154b4
to
e9e4de8
Compare
|
@englehardt PTAL, thanks. I added a step to the Storage-model algorithm because I realized that cookies can be created without parsing a set-cookie-line (e.g. through the CookieStore API). |
englehardt
pushed a commit
to englehardt/wpt
that referenced
this pull request
Mar 29, 2021
englehardt
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
This LGTM. Thanks @chlily1!
I've added some wpts for this in web-platform-tests/wpt#28290. Firefox fails when CR is present, Chrome/Edge when NUL is present, and Safari when other CTL characters are present. But I think the new language here is the right thing to target.
|
Thanks for the review, and thank you for adding the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explicit steps to handle control characters in set-cookie-strings.