Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Fix an issue in ParseCode method 2. Add new additional Inspect method #3

Merged
merged 3 commits into from
Dec 30, 2013

Conversation

kzvankovich
Copy link

  1. Fix an issue in ParseCode method :
    During exchanging code for an access token I got the following error: redirect_uri isn't an absolute URI. Check RFC 3986.
  2. Add new additional Inspect method:
    added Inspect Session access token functionality

@huandu huandu merged commit 84e877f into huandu:master Dec 30, 2013
@huandu
Copy link
Owner

huandu commented Dec 30, 2013

Hi @kostjazvankovich , thanks for your fix!

I merge your changes with following modifications.

  • Remove the second parameter of app.ParseCode and use app.RedirectUri instead. Per facebook's document, redirect uri must be the set to the exact value in the app's configuration. So it should be considered as an app config like app id and secrect.
  • use gofmt -tabs=false -tabwidth=4 -w . to format code. You used a different way to format code. It makes me a hard time to see diffs.

Again, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants