Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #134 0.76.0: SNS -> publish to subscribed SQS queue, "Records" a… #2

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Fix #134 0.76.0: SNS -> publish to subscribed SQS queue, "Records" a… #2

merged 2 commits into from
Feb 25, 2023

Commits on Feb 25, 2023

  1. Fix mj1618#134 0.76.0: SNS -> publish to subscribed SQS queue, "Recor… 

    …ds" assumption leads to lost message, empty array. mj1618#134

There is no need to check `    if (sub["Attributes"]["RawMessageDelivery"] === "true") ` inside `publishSqs`, this `RawMessageDelivery` check-process is already handled by `publish`.
The `event` object is what should be sent directly to an sqs endpoint.

This also works with serverless-offline-sqs plugin.
    @jimmy-shaojun
    jimmy-shaojun committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    a11eea8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issue_134_publish_to_sqs

    @huangjimmy
    huangjimmy authored Feb 25, 2023
    Configuration menu
    Copy the full SHA
    3935b5d View commit details
    Browse the repository at this point in the history