Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1092] optimize security authentication verification logic #1093

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

chengyouling
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (2f248ce) 0.00% compared to head (9e8b790) 0.00%.
Report is 1 commits behind head on master.

❗ Current head 9e8b790 differs from pull request most recent head 686ab86. Consider uploading reports for the commit 686ab86 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1093   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         117     119    +2     
  Lines        2276    2290   +14     
  Branches      194     196    +2     
======================================
- Misses       2276    2290   +14     
Files Coverage Δ
...mon/configration/dynamic/GovernanceProperties.java 0.00% <ø> (ø)
...graceful/ServicecombGracefulAutoConfiguration.java 0.00% <0.00%> (ø)
...iscovery/graceful/ServicecombGracefulEndpoint.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengyouling chengyouling self-assigned this Nov 8, 2023
@@ -18,6 +18,8 @@
package com.huaweicloud.governance.authentication;

import java.util.List;

import org.apache.commons.lang.StringUtils;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use commons lang 3 api if possible.

Copy link
Collaborator Author

@chengyouling chengyouling Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@liubao68 liubao68 merged commit 522f0c8 into master Nov 8, 2023
1 check passed
@chengyouling chengyouling deleted the master_sec branch November 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants