[#1321] add logger request server serviceName/ip/port #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Jul 18, 2024
| @@ -30,6 +30,8 @@ public class GovernanceProperties { | |||
|
|
|||
| public static final int WEB_FILTER_SERVICE_AUTH_ORDER = -60000; | |||
|
|
|||
| public static final int WEB_FILTER_REQUEST_SERVICE_LOGGER_ORDER = -35000; | |||
There was a problem hiding this comment.
WEB_FILTER_REQUEST_LOGGER_ORDER
liubao68
reviewed
Jul 18, 2024
| @@ -56,6 +58,9 @@ public class GovernanceProperties { | |||
| public static final String WEBCLIENT_FAULT_INJECTION_ENABLED = | |||
| PREFIX + "." + "webclient.faultInjection.enabled"; | |||
|
|
|||
| public static final String WEBCLIENT_REQUEST_SERVICE_LOGGER_ENABLED = | |||
There was a problem hiding this comment.
WEBCLIENT_REQUEST_LOGGER_ENABLED
liubao68
reviewed
Jul 18, 2024
| @@ -56,6 +58,9 @@ public class GovernanceProperties { | |||
| public static final String WEBCLIENT_FAULT_INJECTION_ENABLED = | |||
| PREFIX + "." + "webclient.faultInjection.enabled"; | |||
|
|
|||
| public static final String WEBCLIENT_REQUEST_SERVICE_LOGGER_ENABLED = | |||
| PREFIX + "." + "webclient.requestServiceLogger.enabled"; | |||
There was a problem hiding this comment.
requestServiceLogger -> requestLogger
liubao68
reviewed
Jul 18, 2024
|
|
||
| public static void logServiceInfo(InvocationContext context, Throwable e) { | ||
| if (context != null && context.getLocalContext(GovernanceConst.CONTEXT_CURRENT_INSTANCE) != null) { | ||
| if (context.getLocalContext(GovernanceConst.CONTEXT_CURRENT_INSTANCE) instanceof ServiceInstance) { |
There was a problem hiding this comment.
CONTEXT_CURRENT_INSTANCE 还可能是其他类型吗？
liubao68
reviewed
Jul 18, 2024
| } | ||
|
|
||
| private ClientResponse logServiceInfo(ClientResponse response, ClientRequest request) { | ||
| if (response.statusCode() != HttpStatusCode.valueOf(200)) { |
There was a problem hiding this comment.
response.statusCode().value() != 200 or family.isSucceful
|
OK |
chengyouling
added a commit
that referenced
this pull request
Aug 16, 2024
chengyouling
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.