Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable persistent cache support #168

Closed
kohsuke opened this issue Mar 22, 2015 · 2 comments
Closed

Pluggable persistent cache support #168

kohsuke opened this issue Mar 22, 2015 · 2 comments

Comments

@kohsuke
Copy link
Collaborator

kohsuke commented Mar 22, 2015

This is a fall out from issue #104.

It would be nice to leverage conditional get support in GitHub by offering some kind of optional classes that adds persistent cache on the disk.
@kohsuke kohsuke mentioned this issue Mar 22, 2015
Closed
@KostyaSha
Copy link
Contributor

Two lines of code?
https://github.com/KostyaSha/github-pullrequest-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github/pullrequest/GitHubPRTrigger.java#L696-L697

kohsuke added a commit that referenced this issue Mar 22, 2015
@kohsuke
Described how to set up persistent disk cache
e9417f5 
This is good enough "fix" for issue #168.
@kohsuke
Copy link
Collaborator Author

kohsuke commented Mar 22, 2015

Great! I've updated the doc and I consder that a fix for this.

@kohsuke kohsuke closed this as completed Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @KostyaSha