Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHRepository.getCompare(GHBranch, GHBranch) does not allow for cross-fork compares #218

Closed
if6was9 opened this issue Sep 21, 2015 · 1 comment
Closed

GHRepository.getCompare(GHBranch, GHBranch) does not allow for cross-fork compares #218

if6was9 opened this issue Sep 21, 2015 · 1 comment
Labels
bug

Comments

@if6was9
Copy link

if6was9 commented Sep 21, 2015

GHRepository.getCompare(String,String) supports cross-fork comparisons, but this does not:

https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHRepository.java#L684-L686

This is a simple fix.
@if6was9 if6was9 mentioned this issue Sep 21, 2015
Merged
kohsuke added a commit that referenced this issue Dec 1, 2015
@kohsuke
Merge pull request #219 from if6was9/cross-fork-compare
723bb89 
#218 enable cross fork compare
@kohsuke
Copy link
Collaborator

kohsuke commented Dec 3, 2015

Solved by merging PR.

@kohsuke kohsuke closed this as completed Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kohsuke @if6was9 @oleg-nenashev