Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding users to organization-owned repos not possible #317

Closed
ToWi87 opened this issue Dec 2, 2016 · 1 comment
Closed

Adding users to organization-owned repos not possible #317

ToWi87 opened this issue Dec 2, 2016 · 1 comment

Comments

@ToWi87
Copy link

ToWi87 commented Dec 2, 2016

Adding users to organization-owned repositories fails for me due to GHRepository#verifyMine() saying "Operation not applicable to a repository owned by someone else" which is quite correct, still not OK if the logged in user has respective privileges on the repository.

Proposal: remove this check and wait for GitHub to return HTTP 401/403.
kohsuke added a commit that referenced this issue Dec 17, 2016
@kohsuke
Fixed issue #317
3217728 
There's no need for the library to replicate a logic when GitHub does
that (and does that correctly.)

Looking at the commit history, I couldn't see why this was added in the
first place.
@kohsuke
Copy link
Collaborator

kohsuke commented Dec 17, 2016

Indeed. Fixed in 1.82.

@kohsuke kohsuke closed this as completed Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @ToWi87