Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLabels() call for a pull request results in downstream 404s #319

Closed
benpatterson opened this issue Dec 5, 2016 · 2 comments
Closed

getLabels() call for a pull request results in downstream 404s #319

benpatterson opened this issue Dec 5, 2016 · 2 comments

Comments

@benpatterson
Copy link

When calling .getLabels() with a pull request object, the pull request object's url is overridden to include /issues/ in the path, rather than /pulls/. This can cause subsequent 404s when attempting to access pull request-specific API endpoints, like getCommits(), which require a pull request url.

See jenkinsci/ghprb-plugin#441 for some backstory.
kohsuke added a commit that referenced this issue Dec 17, 2016
@kohsuke
Fixed issue #319
3a66e90 
getApiUrl() is unreliable given that we collapse issue & PR into one
object.
@kohsuke
Copy link
Collaborator

kohsuke commented Dec 17, 2016

Fixed in 1.82.

@kohsuke kohsuke closed this as completed Dec 17, 2016
@benpatterson
Copy link
Author

Thanks for the fix! We'll look to incorporate it downstream. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @benpatterson