Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch name is not being correctly URL encoded #381

Closed
stephenc opened this issue Sep 25, 2017 · 3 comments
Closed

Branch name is not being correctly URL encoded #381

stephenc opened this issue Sep 25, 2017 · 3 comments

Comments

@stephenc
Copy link
Contributor

See https://issues.jenkins-ci.org/browse/JENKINS-46898

Seems # is a valid character in a branch name but the URLs are not being correctly constructed causing it to be interpreted by GitHub as a document fragment identifier
martinvanzijl added a commit to martinvanzijl/github-api that referenced this issue Dec 9, 2018
@martinvanzijl
Issue hub4j#381 - Escape branch URL.
87d7314 
This is using the "old" HTTP.UTF_8 Charset, since the new
StandardCharsets doesn't compile.
@martinvanzijl martinvanzijl mentioned this issue Dec 9, 2018
Merged
@rmetzger
Copy link
Contributor

I ran into the same issue with labels. For example a label "approved?" will not be resolved correctly.

bitwiseman pushed a commit to martinvanzijl/github-api that referenced this issue Sep 26, 2019
@martinvanzijl @bitwiseman
Issue hub4j#381 - Escape branch URL.
a50a011 
This is using the "old" HTTP.UTF_8 Charset, since the new
StandardCharsets doesn't compile.
@bitwiseman
Copy link
Member

@rmetzger
That's a separate issue, please file it.

@bitwiseman
Copy link
Member

This issue has been fixed. It will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmetzger @stephenc @bitwiseman