Picking endpoint from the properties file and environment variables #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps seemless switching between public github and enterprise without any code changes
|
Kohsuke Kawaguchi » github-api #280 SUCCESS |
| @@ -70,7 +70,7 @@ public static GitHubBuilder fromCredentials() throws IOException { | |||
|
|
|||
| } | |||
|
|
|||
| public static GitHubBuilder fromEnvironment(String loginVariableName, String passwordVariableName, String oauthVariableName) throws IOException { | |||
| public static GitHubBuilder fromEnvironment(String loginVariableName, String passwordVariableName, String oauthVariableName, String endpointVariableName) throws IOException { | |||
There was a problem hiding this comment.
Will broke backward compatibility
|
Kohsuke Kawaguchi » github-api #293 SUCCESS |
kohsuke
added a commit
that referenced
this pull request
Mar 15, 2015
Picking endpoint from the properties file and environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps seemless switching between public github and enterprise without any code changes.