Enable creation and retrieval of org webhooks #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made GHHook abstract and created two concrete subclasses for org and repo hooks. Created utility class GHHooks to manage creation and retrieval of org/repo hooks with minimal code duplication. These are invoked by GHOrganization and GHRepository respectively.
|
Kohsuke Kawaguchi » github-api #343 SUCCESS |
| @@ -57,14 +57,14 @@ | |||
| private int watchers,forks,open_issues,size,network_count,subscribers_count; | |||
| private String pushed_at; | |||
| private Map<Integer,GHMilestone> milestones = new HashMap<Integer, GHMilestone>(); | |||
|
|
|||
There was a problem hiding this comment.
please avoid such empty-line changes
|
I like the idea with the helper class BTW |
kohsuke
added a commit
that referenced
this pull request
Jul 17, 2015
Changing GHHook to abstract is a binary incompatible change in theory, but given the way this class is designed it is difficult to imagine any client code instantiating this class. So I think it is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made GHHook abstract and created two concrete subclasses for org
and repo hooks. Created utility class GHHooks to manage creation
and retrieval of org/repo hooks with minimal code duplication. These
are invoked by GHOrganization and GHRepository respectively.
Additional info on org webhooks here: https://developer.github.com/v3/orgs/hooks/
Note: requires #189 to test creation of org/repo hooks