Fix #252: infinite loop because the "hypertext engine" generates invalid URLs

[cyrille-leclerc]

Fix #252: infinite loop because the "hypertext engine" may duplicate the ? char generating invalid https://api.github.com/notifications?all=true&page=2?all=true instead of https://api.github.com/notifications?all=true&page=2&all=true.

A better fix will be to prevent duplication of parameters (all=true in this case).

[cyrille-leclerc]

@reviewbybees esp @recena

[cyrille-leclerc]

Note: I preferred to concatenate on a String with += instead of using StringBuilder for better readability as the perf impact is very limited (very small number of query params added).

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[jglick]

🐝