Added support for the extended stargazers API in Github V3 API #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public PagedIterator<GHStargazer> _iterator(int pageSize) { | ||
| Requester requester = root.retrieve(); | ||
| requester.setHeader("Accept", "application/vnd.github.v3.star+json"); |
There was a problem hiding this comment.
Will it continue working with previous APIs? E.g. on old GitHub Enterprise instances
There was a problem hiding this comment.
Good question - don't think so, good catch.
Maybe it should have both versions supported
There was a problem hiding this comment.
Added back the old version for compatibility and also listExtendedStargazers to return the new version. In addition added Javadoc to link both methods :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github has added starred_at date to stargazers when stargazers are requested with a special (new) version on the REST API. Added support for the version and a type representing the additional information.