Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repository searching by "topic" #439

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Jun 6, 2018

@ToWi87
Copy link

ToWi87 commented Jun 7, 2018

👍 for the idea and the code, here the related docs:
https://developer.github.com/v3/search/#search-topics
Question coming up here:
Are there no additions needed regarding the additional header needed as stated in the docs?

Copy link
Collaborator

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@l3ender
Copy link
Contributor Author

l3ender commented Jun 7, 2018

@ToWi87 The doc you linked to is for searching/retrieving topics (/search/topics). This PR is for using topics to search/retrieve repositories (/search/repositories).

If/when there is a desire to integrate searching of topics, then there will likely be need to spend effort on the header information that you mentioned.

Thank you.

@ToWi87
Copy link

ToWi87 commented Jun 8, 2018

true that, sorry for the confusion.
I'd like to have the search API also work for topics but I'd wait for GitHub to release the feature without the 'beta' header.

@kohsuke kohsuke merged commit ca55947 into hub4j:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants