Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for draft pull requests #525

Merged
merged 8 commits into from
Oct 21, 2019
Merged

Conversation

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, now we just need some tests. I've invited you as a collaborator on the test repo, you should be able to use it to write some tests. See CONTRIBUTING for details.

@sullis
Copy link
Contributor

sullis commented Oct 11, 2019

any update on this PR? I'd like to start using Draft Pull Requests :)

@bitwiseman
Copy link
Member

@sullis
We need tests that show this working in CI. Could you implement them?

@vbehar
Copy link
Contributor Author

vbehar commented Oct 14, 2019

Hi,
sorry for not being more active on this one. I'll try to work on the tests this week.
@sullis if you want to do it, please feel free to do so ;-)

@bitwiseman bitwiseman merged commit 72d4b9b into hub4j:master Oct 21, 2019
@vbehar
Copy link
Contributor Author

vbehar commented Oct 22, 2019

thanks @bitwiseman for finishing this and adding the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants