-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for team pr review requests #532
Add support for team pr review requests #532
Conversation
Hey @bitwiseman - any chance of getting some PR review here? :) |
@farmdawgnation I've resolve the merge conflict, but haven't done a build or further test. Could you try the instructions in CONTRIBUTING.md for creating new tests and snapshots of github response data? It is still a little rough around the edges, but I think it will be a big step forward for testing and stability. I've invited you to be a collaborator in the test repo that we're using. I think that's all you'll need from me. Thanks in advance. If you don't have time, I'll get back to it later this week. |
GHUser kohsuke2 = gitHub.getUser("kohsuke2"); | ||
p.requestReviewers(Collections.singletonList(kohsuke2)); | ||
assertFalse(p.getRequestedReviewers().isEmpty()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farmdawgnation
Good test for requestReviewers
, next you'll do a test for requestTeamReviewers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will.
I can give it a shot, but I may first attempt to write a test using the existing format for time's sake. |
@bitwiseman I've gotten the wiremock data in place for the existing test I wrote and tests now pass locally for me. However, because I was added as an outside collaborator on a single repository it seems I don't have the ability to see what teams exist in github-api-test-org or tag them in reviews so I still can't write my test for the team pr reviews feature. Could you please add a team that has the kohsuke2 user in it and make it so that I can see it? |
Hm my tests are failing in CI, but they work locally. Seeing this in the CI log:
What did I do wrong here? |
@farmdawgnation Try deleting your wiremock data, rebasing/merging from master, and running again. I've made a bunch of fixes and improvements to the framework. |
@farmdawgnation |
Word, I'll try to get it in :) |
We don't get the full object when we retrieve a PR, so when we see requested teams we need to materialize them from the API
Yay! tests pass! |
This PR adds support for team pr review requests. Added a test that covers individual review requests but I'm pretty sure the github-api-test-org will need a team added for me to test team review requests.