-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for projects #545
Support for projects #545
Conversation
return this; | ||
} | ||
|
||
private void edit(String key, Object value) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of the builder/updater style instead?
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHRelease.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseBuilder.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseUpdater.java
It would reduce round trips but would add more code.
I don't have a strong opinion. The project doesn't seem to have one particular style it uses, I'd like to move toward a more consistent style. I'm wondering what you think.
(Maybe @kohsuke can comment as well if he's around.)
/** | ||
* Returns the projects for this organization. | ||
* @param status The status filter (all, open or closed). | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*/ | |
*/ | |
@Preview @Deprectated |
Fixes issue hub4j#425
…cts, columns and cards
ef7e4fb
to
d787359
Compare
d787359
to
5cc88a0
Compare
Need to mock raw.githubusercontent.com to make this work
40fe212
to
20cfb26
Compare
An extension of #483 where project columns and cards have been added, as well as some tests