Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for projects #545

Merged
merged 8 commits into from
Oct 5, 2019

Conversation

gskjold
Copy link
Contributor

@gskjold gskjold commented Sep 19, 2019

An extension of #483 where project columns and cards have been added, as well as some tests

return this;
}

private void edit(String key, Object value) throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gskjold

What do you think of the builder/updater style instead?

https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHRelease.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseBuilder.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseUpdater.java

It would reduce round trips but would add more code.

I don't have a strong opinion. The project doesn't seem to have one particular style it uses, I'd like to move toward a more consistent style. I'm wondering what you think.

(Maybe @kohsuke can comment as well if he's around.)

/**
* Returns the projects for this organization.
* @param status The status filter (all, open or closed).
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*/
*/
@Preview @Deprectated

@bitwiseman bitwiseman force-pushed the issue_425_projects_columns_cards branch from ef7e4fb to d787359 Compare October 4, 2019 17:11
@bitwiseman bitwiseman force-pushed the issue_425_projects_columns_cards branch from d787359 to 5cc88a0 Compare October 4, 2019 17:28
Need to mock raw.githubusercontent.com to make this work
@bitwiseman bitwiseman force-pushed the issue_425_projects_columns_cards branch from 40fe212 to 20cfb26 Compare October 4, 2019 18:09
@bitwiseman bitwiseman merged commit 8450173 into hub4j:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants