Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code improvements #118

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Minor code improvements #118

merged 6 commits into from
Jun 24, 2024

Conversation

lshandross
Copy link
Contributor

No description provided.

@lshandross lshandross linked an issue Jun 20, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 20, 2024

Copy link
Contributor

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all seems fine, though frankly i am unclear on when it is/is not ok to use .data

R/validate_ensemble_inputs.R Outdated Show resolved Hide resolved
@lshandross
Copy link
Contributor Author

this all seems fine, though frankly i am unclear on when it is/is not ok to use .data

From what I understand, ".data$" specifically (with the "$" sign) should not be used within tidyverse functions; instead, column names should be surrounded with double quotes. However, there are certain instances where using double quotes doesn't play nicely, and in those cases the alternative syntax used should be .data[["col_name"]].

@lshandross lshandross merged commit 050729d into main Jun 24, 2024
8 checks passed
@lshandross lshandross deleted the minor-code-improvements branch August 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace superseded functions
2 participants