-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ensemble #4
Conversation
based on Issue #1 draft code
minor suggestion without having looked at the code: to avoid magrittr import, could we just use the base pipe of |
We had discussed the question of which pipe to use in the context of |
Noting that current R CMD CHECK failures are due to undocumented parameters -- but those are the parameters that will be passed on to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just a couple of comments/questions.
Also, regarding R CMD CHECK complaining about missing params, fine to ignore, but if you did want to complete the parameters to fix the warning, I could then transfer them to the hubUtils::as_model_out_df()
docs and change the inherit params here when it's time?
Co-authored-by: Anna Krystalli <[email protected]>
No description provided.