Replace einops.rearrange with torch native #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to lllyasviel/stable-diffusion-webui-forge#716 (comment),
einops.rearrange
calls in crossattn is causing extra overhead. Replacing it with torch native ops can save ~55ms/it.Screenshots/videos:
TODO
There are other places where
einops.rearrange
can be replaced by torch native ops, but this one in CrossAttn is the most critical one. Instrument the usage ofeinops.rearrange
elsewhere might also yield some improvements.Checklist: