Skip to content

Commit

Permalink
pythongh-121596: Fix Sharing Interpreter Channels (pythongh-121597)
Browse files Browse the repository at this point in the history
This fixes a mistake in pythongh-113012 and adds a test that verifies the fix.
  • Loading branch information
ericsnowcurrently authored and noahbkim committed Jul 11, 2024
1 parent 75928ec commit cd6480c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
18 changes: 18 additions & 0 deletions Lib/test/test_interpreters/test_channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def test_list_all(self):
self.assertEqual(after, created)

def test_shareable(self):
interp = interpreters.create()
rch, sch = channels.create()

self.assertTrue(
Expand All @@ -60,8 +61,25 @@ def test_shareable(self):
rch2 = rch.recv()
sch2 = rch.recv()

interp.prepare_main(rch=rch, sch=sch)
sch.send_nowait(rch)
sch.send_nowait(sch)
interp.exec(dedent("""
rch2 = rch.recv()
sch2 = rch.recv()
assert rch2 == rch
assert sch2 == sch
sch.send_nowait(rch2)
sch.send_nowait(sch2)
"""))
rch3 = rch.recv()
sch3 = rch.recv()

self.assertEqual(rch2, rch)
self.assertEqual(sch2, sch)
self.assertEqual(rch3, rch)
self.assertEqual(sch3, sch)

def test_is_closed(self):
rch, sch = channels.create()
Expand Down
4 changes: 2 additions & 2 deletions Modules/_interpchannelsmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -2615,10 +2615,10 @@ _get_current_channelend_type(int end)
}
if (cls == NULL) {
// Force the module to be loaded, to register the type.
PyObject *highlevel = PyImport_ImportModule("interpreters.channel");
PyObject *highlevel = PyImport_ImportModule("interpreters.channels");
if (highlevel == NULL) {
PyErr_Clear();
highlevel = PyImport_ImportModule("test.support.interpreters.channel");
highlevel = PyImport_ImportModule("test.support.interpreters.channels");
if (highlevel == NULL) {
return NULL;
}
Expand Down

0 comments on commit cd6480c

Please sign in to comment.