Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

various fixes and features #218

Merged
merged 8 commits into from
Oct 18, 2022
Merged

various fixes and features #218

merged 8 commits into from
Oct 18, 2022

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 17, 2022 •
edited
Loading

Overview

@refcell refcell requested a review from clabby October 17, 2022 21:40
@refcell refcell changed the title feat: Transient Opcodes and Push Overrides various fixes and features Oct 17, 2022
clabby
clabby suggested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

huff_utils/src/ast.rs Outdated Show resolved Hide resolved
huff_parser/tests/opcodes.rs Show resolved Hide resolved
huff_codegen/src/lib.rs Show resolved Hide resolved
@refcell refcell requested a review from clabby October 18, 2022 15:15
@refcell refcell self-assigned this Oct 18, 2022
@refcell refcell added the bug Code Smells label Oct 18, 2022
clabby
clabby suggested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! push<n> has unexpected behavior if the literal isn't n bytes in size, but the __codesize fix is great 😄

huff_parser/tests/opcodes.rs Show resolved Hide resolved
@refcell refcell requested a review from clabby October 18, 2022 20:04
@refcell refcell mentioned this pull request Oct 18, 2022
Merged
3 tasks
clabby
clabby approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM king 💯

@refcell refcell merged commit ab41d45 into stage Oct 18, 2022
This was referenced Oct 18, 2022
Merged
Closed
@refcell refcell deleted the @abigger87/opcodes/transient branch February 26, 2023 19:00
@Maddiaa0 Maddiaa0 mentioned this pull request Feb 27, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
bug Code Smells
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby