Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

fix(huffup): Check if command exists before using it #257

Merged
merged 3 commits into from
Mar 12, 2023
Merged

fix(huffup): Check if command exists before using it #257

merged 3 commits into from
Mar 12, 2023

Conversation

lambda-0x
Copy link
Contributor

Overview

Only attempt to uninstall older huffc compiler if that specific package manager is installed.

Without this everytime i run huffup, i see:

~/.huff/bin/huffup: line 25: yarn: command not found

Maddiaa0
Maddiaa0 previously approved these changes Mar 12, 2023
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@Maddiaa0 Maddiaa0 changed the base branch from main to stage March 12, 2023 07:35
@Maddiaa0 Maddiaa0 dismissed their stale review March 12, 2023 07:35

The base branch was changed.

Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

@Maddiaa0 Maddiaa0 merged commit 03401a8 into huff-language:stage Mar 12, 2023
@Maddiaa0 Maddiaa0 mentioned this pull request Mar 12, 2023
@lambda-0x lambda-0x deleted the fix-huffup branch March 12, 2023 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants