This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Update Benchmark Expected Initcode #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before this PR, running
cargo benchpanics in the following file:huff_core/benches/huff_benchmark.rs.The reason for the panic is the (partially) auto-generated initcode has changed since the
expected_bytecodewas hard coded.Previous initcode:
new initcode:
This PR updates the initcode and removes the panic. A subsequent discussion should address this to ensure that code-generation changes don't break benchmarks in the future.