Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's my first contribution here, so let me say: awesome project, I love it, thank all of you for it!
I used hug for my project and I found a problem how to include a database connection (in my case sqlalchemy session) to the project. While searching for the solution I found some issues that also mention this problem: #376 and #458.
In the PR I included my solution to the problem - a class-based directive with a method for a cleanup when something goes wrong. In examples I included two use cases: sqlalchemy and mail sending. I will be happy to include more.
One nice thing about solution is that annotation still preserves its basic functionality - a smtp variable is an object of SMTP class.
Any comments are welcome, thanks!