[VAE] fix the downsample block in Encoder. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
anton-l
approved these changes
Aug 6, 2022
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* pass downsample_padding in encoder * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VAE
encoderis currently broken, as we don't passdownsample_paddingtoget_down_block, so it defaults toNoneinDownEncoderBlock2D. This PR fixes this by passingdownsample_padding=0inget_down_blockin theEncoder.This issue was not caught in tests as the dummy models in test uses only one up/down sampling block, and the VAE models don't add the Up/Down sampling in the last block which in this case is the first block.
@anton-l @patrickvonplaten Let's make sure to add at least two blocks when creating dummy models for tests.