Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pipeline Slow Test runners #5131

Merged
merged 29 commits into from
Oct 4, 2023
Merged

New Pipeline Slow Test runners #5131

merged 29 commits into from
Oct 4, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Sep 21, 2023

What does this PR do?

Changes the slow push tests to only run on core + high usage pipelines.

This PR:

  1. Adds a utils/fetch_torch_cuda_pipeline_test_matrix.py script that fetches a list of high usage pipelines from the hub and extracts their corresponding modules along with core pipeline modules that are defined in the script.
  2. Changes push_tests.yml to run the fetched + core pipelines in parallel. This isolates pipeline tests by modules
  3. Changes kandinksy_v22 and text_to_video folder names to kandinksy2_2 and text_to_video_synthesis so that they match with the module names in src/diffusers. This is done so that Github actions can run the correct tests for a module.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 changed the title New test runners New Pipeline Slow Test runners Sep 21, 2023
@DN6
Copy link
Collaborator Author

DN6 commented Sep 21, 2023

@patrickvonplaten I want to test this out on the actual runners before merging. Could you please let me know how I can change actions so that they run on this branch?

@patrickvonplaten
Copy link
Contributor

@patrickvonplaten I want to test this out on the actual runners before merging. Could you please let me know how I can change actions so that they run on this branch?

123bb9d


jobs:
run_slow_tests:
setup_torch_cuda_pipeline_matrix:
runs-on: docker-cpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The push tests should definitely still run on GPU, the only difference here should maybe just be that the RUN_SLOW flag is set to False instead of True. So we run the fast tests but on GPU this time

.github/workflows/push_tests.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,96 @@
import json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patrickvonplaten
Copy link
Contributor

Design looks great! Let me know once this is ready for a full review!

@DN6
Copy link
Collaborator Author

DN6 commented Sep 29, 2023

@patrickvonplaten This is ready for review. I'm seeing a couple of issues with compile tests and loras, but I think we can just fix those after merging this.

.github/workflows/push_tests.yml Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 2, 2023

The documentation is not available anymore as the PR was closed or merged.

@DN6 DN6 merged commit dd5a362 into main Oct 4, 2023
13 checks passed
rchuzh99 pushed a commit to rchuzh99/diffusers that referenced this pull request Oct 4, 2023
* pipline fetcher

* update script

* clean up

* clean up

* clean up

* new pipeline runner

* rename tests to match modules

* test actions in pr

* change runner to gpu

* clean up

* clean up

* clean up

* fix report

* fix reporting

* clean up

* show test stats in failure reports

* give names to jobs

* add lora tests

* split torch cuda tests and add compile tests

* clean up

* fix tests

* change push to run only on main

---------

Co-authored-by: Patrick von Platen <[email protected]>
@kashif kashif deleted the new-test-runners branch December 5, 2023 09:00
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* pipline fetcher

* update script

* clean up

* clean up

* clean up

* new pipeline runner

* rename tests to match modules

* test actions in pr

* change runner to gpu

* clean up

* clean up

* clean up

* fix report

* fix reporting

* clean up

* show test stats in failure reports

* give names to jobs

* add lora tests

* split torch cuda tests and add compile tests

* clean up

* fix tests

* change push to run only on main

---------

Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* pipline fetcher

* update script

* clean up

* clean up

* clean up

* new pipeline runner

* rename tests to match modules

* test actions in pr

* change runner to gpu

* clean up

* clean up

* clean up

* fix report

* fix reporting

* clean up

* show test stats in failure reports

* give names to jobs

* add lora tests

* split torch cuda tests and add compile tests

* clean up

* fix tests

* change push to run only on main

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants