Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error of peft lora when xformers enabled #5506

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix error of peft lora when xformers enabled #5506

merged 2 commits into from
Oct 25, 2023

Conversation

AnyISalIn
Copy link
Contributor

What does this PR do?

Fixes (#5504)

Before submitting

  • [ x ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ x ] Did you read the contributor guideline?
  • [ x ] Did you read our philosophy doc (important for complex PRs)?
  • [ x ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ x ] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • [ x ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

This was referenced Oct 24, 2023
Closed
Closed
younesbelkada
younesbelkada approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me thanks for fixing!

sayakpaul
sayakpaul approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works for me. Thanks for fixing!

@sayakpaul sayakpaul merged commit de71fa5 into huggingface:main Oct 25, 2023
11 checks passed
@okotaku okotaku mentioned this pull request Nov 8, 2023
Merged
6 tasks
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
@AnyISalIn @kashif
fix error of peft lora when xformers enabled (huggingface#5506)
d6ee760 
Signed-off-by: AnyISalIn <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@AnyISalIn
fix error of peft lora when xformers enabled (huggingface#5506)
1a84022 
Signed-off-by: AnyISalIn <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@AnyISalIn
fix error of peft lora when xformers enabled (huggingface#5506)
d111178 
Signed-off-by: AnyISalIn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnyISalIn @sayakpaul @patrickvonplaten @younesbelkada