-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize DPM++, especially for SDXL and SDE-DPM++ #5541
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2748765
stabilize dpmpp for sdxl by using euler at the final step
LuChengTHU 892fec9
add lu's uniform logsnr time steps
LuChengTHU 2f4b5c4
add test
LuChengTHU a0df7b3
fix check_copies
LuChengTHU 3ba3ef4
fix tests
patrickvonplaten 41de793
Merge branch 'main' into stabilize-dpmsolver
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
euler_at_final
to beTrue
? you mentioned there is a tradeoff in image details but I think artifacts are much more undesirablelower_order_final
now we haveeuler_at_final
- we can strongly recommend to seteuler_at_final
to beTrue
when using less than15
stepsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave
euler_at_final
asFalse
since the current default setting works great for SDv15. SDXL seems to be more of a special case hereDon't think we should deprecate it. Already for backwards compatibility reasons we'll need to keep the two and again I think we should be careful to not destroy a functioning, well-working scheduler setting for SDv15.
Essentially, what is done here is to give the user a possibility to have
lower_order_final=True
even for models where we use more than 15 inference steps, but this should not come at the expense of breaking existing workflows, so I don't think we can defaulteuler_at_final
to True or that we can removelower_order_final
Instead of adding
euler_at_final
, we could add a parameter, calledenable_lower_order_below: int = 15
that we allow user to set to 1000 for SDXL. But I'm not sure that this is easier to understand / cleaner actually. So ok to leave as is for me!