Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves an unchanging operation out of a loop for a speed benefit during model loading. It does not change the functional behaviour in any way.
Explanation
The following code was used to profile model loading:
Before:
The resultant .prof file can be visualized with
snakeviz
. This revealed that a significant amount of time was being spent on redundant calls toinspect.signature(....)
:After:
After the improvement in this PR, the time spent on calls to
inspect.signature(....)
was reduced from 0.0340s to 0.0001s:Aside
You may be wondering: "Why does this guy care about such a small slice of the flamegraph?".
A: I've already optimized many of the slower model loading steps (via torch monkey-patches), to the point where this is non-negligible. (And, it seemed like an easy fix.)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.