Multi-image masking for single IP Adapter #7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiorigano
changed the title
sayakpaul
reviewed
Mar 28, 2024
sayakpaul
reviewed
Mar 28, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
thank you @sayakpaul ready |
fabiorigano
changed the title
sayakpaul
reviewed
Apr 1, 2024
sayakpaul
reviewed
Apr 1, 2024
| @@ -544,3 +544,33 @@ def test_ip_adapter_multiple_masks(self): | |||
|
|
|||
| max_diff = numpy_cosine_similarity_distance(image_slice, expected_slice) | |||
| assert max_diff < 5e-4 | |||
|
|
|||
| def test_ip_adapter_multiple_masks_one_adapter(self): | |||
There was a problem hiding this comment.
This is slow test. I was wondering if it's possible to add a fast test like
?
There was a problem hiding this comment.
I see, I missed that
I'll add it now
Co-authored-by: Sayak Paul <[email protected]>
yiyixuxu
reviewed
Apr 3, 2024
Co-authored-by: YiYi Xu <[email protected]>
|
@yiyixuxu @sayakpaul now it's ready |
yiyixuxu
approved these changes
Apr 8, 2024
Closed
|
thank you YiYi! I fixed the fast test for the panorama pipeline that was failing and the slow test I ran all the slow tests related to image masking locally and they didn't break :) |
XSE42
added a commit
to XSE42/diffusers3d
that referenced
this pull request
Apr 30, 2024
diffusers commit a0cf607
Multi-image masking for single IP Adapter
(huggingface/diffusers#7499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Image masking is currently supported by passing a mask and an image for each IP Adapter in the pipeline.
This PR extends this usage by allowing multiple masks and images to be passed to a single IP Adapter. Scales must be passed accordingly.
Discussed in #7419
@sayakpaul @yiyixuxu