Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checkpoint key used to identify CLIP models in single file checkpoints #8319

Merged
merged 2 commits into from
May 31, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented May 30, 2024

What does this PR do?

Some single file checkpoints do not include a position ids key for the CLIP model. This can cause issues loading the CLIP model as we cannot detect it in the checkpoint, such as #8228.

This PR changes the checkpoint key to the position embeds weights key which should always be present in the checkpoint.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 merged commit f9fa8a8 into main May 31, 2024
17 checks passed
@vladmandic
Copy link
Contributor

@yiyixuxu @DN6 this may necessitate a service release (0.28.1) given how frequent are those models?

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jun 3, 2024

@vladmandic
does this affect a lot of checkpoints? I did not know that
but yeah we're going to a patch release and will include this fix!

yiyixuxu pushed a commit that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants