[CI] updates to the CI report naming, and accelerate installation
#9429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
reviewed
Sep 12, 2024
ydshieh
reviewed
Sep 12, 2024
sayakpaul
changed the title
accelerate installation
sayakpaul
commented
Sep 13, 2024
| name: ${{ matrix.config.report }}_test_reports | ||
| name: tests_onnx_cuda_reports |
There was a problem hiding this comment.
Because we don't have a matrix here.
sayakpaul
commented
Sep 13, 2024
| --make-reports=tests_${{ matrix.config.report }} \ | ||
| --make-reports=tests_${{ matrix.lib-versions }} \ |
There was a problem hiding this comment.
This change:
- Removes the faulty
matrix.config.reportbecause there's nothing called config in the matrix. - Adds
lib-version(which is in thematrix) to make the names unique.
sayakpaul
commented
Sep 13, 2024
|
|
||
| - name: Test suite reports artifacts | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: pr_${{ matrix.config.report }}_test_reports | ||
| name: pr_${{ matrix.lib-versions }}_test_reports |
There was a problem hiding this comment.
So that the artifact is uploaded with a unique name.
sayakpaul
commented
Sep 13, 2024
| @@ -170,7 +170,7 @@ jobs: | |||
| if: ${{ always() }} | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: pr_${{ matrix.config.report }}_test_reports | |||
| name: pr_${{ matrix.config.framework }}_${{ matrix.config.report }}_test_reports | |||
There was a problem hiding this comment.
To preserve uniqueness.
There was a problem hiding this comment.
this one seems to be ok - config.report already named nicely with framework taken into account
|
@yiyixuxu can you give this a review? |
yiyixuxu
approved these changes
Sep 16, 2024
| @@ -170,7 +170,7 @@ jobs: | |||
| if: ${{ always() }} | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: pr_${{ matrix.config.report }}_test_reports | |||
| name: pr_${{ matrix.config.framework }}_${{ matrix.config.report }}_test_reports | |||
There was a problem hiding this comment.
this one seems to be ok - config.report already named nicely with framework taken into account
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
…uggingface#9429) * chore: id accordingly to avoid duplicates. * update properly. * updates * updates * empty * updates * changing order helps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
accelerateis updated properly when it's installed from the source. Can confirm that is resolve the bugs we where seeing in_get_named_parameters()seems to have met a regression accelerate#3087.Running https://github.com/huggingface/diffusers/actions/runs/10843159254/job/30089905695 to see things went alright. The purpose of the run is to make sure the artifacts get correctly uploaded.