[LoRA] Handle DoRA better #9547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Oct 1, 2024
|
@BenjaminBossan thanks. Does a8fdc76 work for you? @yiyixuxu could you give this a look too? |
yiyixuxu
reviewed
Oct 7, 2024
| @@ -1125,7 +1136,13 @@ def load_lora_weights( | |||
| # First, ensure that the checkpoint is a compatible one and can be successfully loaded. | |||
| state_dict = self.lora_state_dict(pretrained_model_name_or_path_or_dict, **kwargs) | |||
|
|
|||
| is_correct_format = all("lora" in key or "dora_scale" in key for key in state_dict.keys()) | |||
| is_dora_scale_present = any("dora_scale" in k for k in state_dict) | |||
| if is_dora_scale_present: | |||
There was a problem hiding this comment.
I see that we sometimes add this code to lora_state_dict() and sometimes on load_lora_weights. Is there any reason we do this differently?
There was a problem hiding this comment.
Update: I see what you mean. Will update accordingly.
|
Failing test is unrelated. |
charchit7
pushed a commit
to charchit7/diffusers
that referenced
this pull request
Oct 8, 2024
* handle dora. * print test * debug * fix * fix-copies * update logits * add warning in the test. * make is_dora check consistent. * fix-copies
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
* handle dora. * print test * debug * fix * fix-copies * update logits * add warning in the test. * make is_dora check consistent. * fix-copies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our support for loading community DoRA checkpoints is currently broken. See KohakuBlueleaf/LyCORIS#216.
So, this PR:
dora_scalepresent. Upon detection, it logs a warning about the incompatibility and filters the state dict so that it doesn't have thedora_scalekeys.Once Ben gives a go ahead I will request for a review from Yiyi.