Add countDownloads for Oasis #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-q
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Wauplin
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Thanks @julian-q for the PR :) I've made a few comments to address.
Before getting this merged, there should be at least one model listed on https://huggingface.co/models?other=open-oasis. To do that, you need to update the repo model card and add library_name: open-oasis in the metadata section. This way, the Hub will be able to link your model to your library.
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
|
Fantastic, thank you so much for the fixes @Wauplin . I see the model in https://huggingface.co/models?other=open-oasis! Is everything good to merge now? |
Wauplin
approved these changes
Nov 2, 2024
|
Hmm maybe we should add a "build" as required step before merging 🤔 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add download counting support for https://huggingface.co/Etched/oasis-500m. It matches
.ptfiles in order to match both the autoencoder and the diffusion model.The relevant github repository (used for inferencing the model) is https://github.com/etched-ai/open-oasis.