Do not remove None values in RepoCardData serialization #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
approved these changes
Oct 22, 2024
hanouticelina
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM! ruff formatting tests/test_repocard_data.py + the fixes made in #2621 should make the CI green ✅
|
Thanks for the quick reviews :) |
Wauplin
deleted the
do-not-remove-none-values-in-repocard-serizalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in huggingface/datasets#7243 (comment) and especially huggingface/datasets#7243 (comment).
When serializing repo cards metadata, we are currently removing any none values from any dictionary, set, list or tuple. This is done since the module has been introduced in #940 and never caused problems until huggingface/datasets#7243 was reported. I do find automatically removing None values inside values to be pretty clunky as it is values set by the user and not default ones.
This PR updates this behavior to remove only top-level None values, i.e. values that are None by default and that therefore shouldn't be serialized (as not set by the users themselves). The
_remove_nonehelper is still kept to remove None values from the model-index (where it's rightfully necessary), but that's all.