Allow https://huggingface.co/ prefix #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be ok with merging this, but I feel like in terms of API it should probably be implemented in Asteroid (or another client library) if you need it, no? I don't have a strong opinion though, so I'll leave this open and see if others want to chime in. |
|
Sorry, I'm late about that. What do we decide? |
|
sorry about the delay here. I'd rather not do it here and leave it to the library, but I'll export |
julien-c
pushed a commit
that referenced
this pull request
May 21, 2021
Added Arabic to the widget. commit imported from https://github.com/huggingface/widgets/commit/0624daaa5b560b86d8bd3cb0c69a2627ec84ced2 Added Arabic to the widget.
julien-c
pushed a commit
that referenced
this pull request
May 21, 2021
Added Arabic to the widget. commit imported from https://github.com/huggingface/widgets/commit/0624daaa5b560b86d8bd3cb0c69a2627ec84ced2 Added Arabic to the widget.
Wauplin
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Bare minimum download path * Bare minimum download path * Providing the sha for file upload * Fixing the download path * Fixing style and quality issues * Conditionally choosing the XET upload path only if the user has hf_xet installed * Remove the need to pass a sha256 into hf_xet (#8) --------- Co-authored-by: Joseph Godlewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in asteroid-team/asteroid#401 I'm submitting a patch to allow repo URLs as download URLs. Curious what you think of the change.