Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise ORTModel documentation #1268

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Aug 11, 2023

As per suggestion #1241 (comment)

Let's merge once the doc PR workflow passes again.

@fxmarty fxmarty requested a review from regisss August 11, 2023 09:43
Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I just spotted a couple of typos.

docs/source/exporters/onnx/usage_guides/export_a_model.mdx Outdated Show resolved Hide resolved
optimum/onnxruntime/modeling_ort.py Outdated Show resolved Hide resolved
@regisss
Copy link
Contributor

regisss commented Aug 12, 2023

@fxmarty I merged #1267 to solve the issue with the doc build. You'll need to rebase on main to have it work here.

edit: actually no, we need to wait for huggingface/doc-builder#392 to be merged. Otherwise, the doc is built but not uploaded.

@fxmarty
Copy link
Contributor Author

fxmarty commented Aug 14, 2023

Thank you @regisss

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 25, 2023

The documentation is not available anymore as the PR was closed or merged.

@fxmarty fxmarty merged commit d7d17eb into huggingface:main Aug 25, 2023
78 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants