Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONNX exporter library_name infer fixes #1460

Merged
merged 2 commits into from
Oct 18, 2023
Merged

ONNX exporter library_name infer fixes #1460

merged 2 commits into from
Oct 18, 2023

Conversation

baskrahmer
Copy link
Contributor

What does this PR do?

Small changes to library_name inference

fxmarty
fxmarty approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Just for my knowledge, do you have an example of model on the Hub where model_info does not have the attribute library_name?

@baskrahmer
Copy link
Contributor Author

@fxmarty I ran into this when exporting meta-llama/Llama-2-7b, before figuring out I should be using meta-llama/Llama-2-7b-hf instead. I guess this is an edge case.

@fxmarty
Copy link
Contributor

fxmarty commented Oct 18, 2023

Thank you. Yes it seems it is broken on the Hub for some reason.

@fxmarty fxmarty merged commit 2f7d396 into huggingface:main Oct 18, 2023
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baskrahmer @fxmarty @bk-jc