-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial Notebook: Using the PEFT library with a DNA Language Model. #1873
Conversation
Thanks, this looks good so far. Ping me once the notebook is ready for review. For general context, check #1837. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@BenjaminBossan this tutorial is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for providing this detailed notebook on DNA-LM training with PEFT. I added a couple of comments, please check them out.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. There are only a few minor issues left.
Also, could you please run the whole notebook before committing it, so that the outputs are directly visible to users without having to run the notebook first.
"train_sequences = []\n", | ||
"val_sequences = []\n", | ||
"\n", | ||
"dataset_limit = 200\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so let's add a comment that this is an optimization for speed, but for best results users should set this variable to None
and use the whole dataset.
@BenjaminBossan I just added the second review changes as you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, we're almost good. Just a few small things:
- Let's add a comment about the data size limit
- Let's not print the model so often, as it clutters the notebook and distracts from the important things
- It would be nice to have a short conclusion, e.g.: How much memory is saved with PEFT? If users want to improve the results, what could they test next?
@BenjaminBossan I added changes from your latest review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this notebook, the last changes LGTM.
This PR adds a tutorial notebook that uses the PEFT library with a DNA Language Model to solve a downstream task.