Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding slice get_dtype() method to get the dtype directly on slices. #303

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Adding slice get_dtype() method to get the dtype directly on slices. #303

merged 1 commit into from
Jul 31, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Jul 31, 2023

What does this PR do?

Fixes #281

Fixes # (issue) or description of the problem this PR solves.

@Narsil Narsil requested a review from sgugger July 31, 2023 13:36
sgugger
sgugger approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, LGTM!

@Narsil Narsil merged commit 1a65a3f into main Jul 31, 2023
9 checks passed
@Narsil Narsil deleted the add_get_slice_dtype branch July 31, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the "meta" device on load_file()
2 participants
@Narsil @sgugger