fix: repack for marlin when single scale is provided #2414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
reviewed
Aug 14, 2024
| @@ -39,7 +39,8 @@ def __init__( | |||
| log_once(logger.info, "GPU does not support FP8, using Marlin FP8 kernel") | |||
|
|
|||
| scales = scales.unsqueeze(0) | |||
| if scales.shape[1] == 1: | |||
| # repack weights for Marlin if a single scale is provided | |||
| if scales.size(0) == 1: | |||
There was a problem hiding this comment.
Suggested change
| if scales.size(0) == 1: | |
| if scales.shape[0] == 1: |
Can you explain where this change is coming from ?
There was a problem hiding this comment.
yea apologies for not including an example above. Currently if attempting to quantize an unquantized model with marlin fp8 the line above will throw when attempting to use marlin to repack.
text-generation-launcher --model-id meta-llama/Meta-Llama-3-8B --quantize fp8
with the change above this model loads and generates as expected
curl 127.0.0.1:3000/generate -X POST -d '{"inputs":"What is Deep Learning?","parameters":{"max_new_tokens":20}}' -H 'Content-Type: application/json'
# {"generated_text":" Deep learning is a subset of machine learning that is inspired by the structure and function of the human brain"}
|
This change doesn' seem to fix neuralmagic/Meta-Llama-3.1-8B-Instruct-FP8 for me |
|
I'm confused this still doesn't fix neural magic. is currently working on Can we introduce a failing test before fixing this ? |
|
Closing as stale, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjust the conditional for repacking fp8 for marlin to run when a single scale is provided. This avoids a
IndexErrorin the case that scales only contain a single value.not
related to: #2388