Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activation function in BERTIntermediate #15

Closed
lukovnikov opened this issue Nov 13, 2018 · 4 comments
Closed

activation function in BERTIntermediate #15

lukovnikov opened this issue Nov 13, 2018 · 4 comments

Comments

@lukovnikov
Copy link
Contributor

BERTConfig is not used for BERTIntermediate's activation function. intermediate_act_fn is always gelu. Is this normal?

https://github.com/huggingface/pytorch-pretrained-BERT/blob/master/modeling.py#L240
@thomwolf
Copy link
Member

Yes, I hard coded that since the pre-trained models are all trained with gelu anyway.

@lukovnikov
Copy link
Contributor Author

lukovnikov commented Nov 13, 2018 •
edited
Loading

ok. but since config is there anyway, isn't it cleaner to use it (to avoid errors for people using configs that use a different activation for some reason) ?

@thomwolf
Copy link
Member

Yes we can, I'll change that in the coming first release (unless you would like to submit a PR which I would be happy to merge).

@lukovnikov
Copy link
Contributor Author

yeah let me clean up and I'll PR

@maeotaku maeotaku mentioned this issue May 23, 2019
Closed
@HongyanJiao HongyanJiao mentioned this issue Sep 19, 2019
Closed
stevezheng23 added a commit to stevezheng23/transformers that referenced this issue Mar 24, 2020
@stevezheng23
Dev/zheng/quac (huggingface#15)
4118441 
* update kd qa in roberta modeling

* fix issues for kd-quac runner

* add adversarial training support for roberta question answering

* add adversarial training support for roberta question answering (cont.)
@philschmid philschmid mentioned this issue Jan 4, 2021
Closed
@manchandasahil manchandasahil mentioned this issue Mar 22, 2021
Closed
2 tasks
@yananchen1989 yananchen1989 mentioned this issue Aug 20, 2021
Closed
rraminen pushed a commit to rraminen/transformers that referenced this issue Oct 27, 2022
@jithunnair-amd
Merge pull request huggingface#15 from ROCmSoftwarePlatform/IFU-maste…
8097220 
…r-2022-08-09

IFU-master-2022-08-09
jlamypoirier added a commit to jlamypoirier/transformers that referenced this issue Apr 4, 2023
@jlamypoirier
Support generic models and arguments (huggingface#15)
5ef38b9
jameshennessytempus pushed a commit to jameshennessytempus/transformers that referenced this issue Jun 1, 2023
@jamesthesnake
Merge pull request huggingface#15 from jamesthesnake/ra
73f8ebf 
Ra
@lwmlyy lwmlyy mentioned this issue Aug 15, 2023
Merged
1 task
ocavue pushed a commit to ocavue/transformers that referenced this issue Sep 13, 2023
@xenova
Merge pull request huggingface#15 from xenova/dependabot/npm_and_yarn…
f8a6f65 
…/webpack-5.76.0

Bump webpack from 5.75.0 to 5.76.0
LysandreJik pushed a commit that referenced this issue Mar 15, 2024
@saurabhdash2512 @ahmetustun
@younesbelkada @Rocketknight1
Cohere Model Release (#29622)
0e4a1c3 
* Cohere Model Release (#1)

Cohere Model Release

* Remove unnecessary files and code (#2)

Some cleanup

* Delete cohere-model directory (#3)

* Make Fix (#5)

* Pr fixes (#6)

* fixes for pr

* pr fixes for the format

* pr fixes for the format

* src/transformers/models/auto/tokenization_auto.py

* Tokenizer test (#8)

* tokenizer test

* format fix

* Adding Docs and other minor changes (#7)

* Add modeling tests (#9)

* Smol Fix (#11)

* tokenization tests are fixed

* format fixes

* fix pr doc tests

* fix pr doc tests

* fix pr doc tests

* fix pr style check

* small changes in cohere.md

* FIX: Address final comments for transformers integration (#13)

* fix modeling final nits and add proper test file

* for now leave empty tests

* add integration test

* push new test

* fix modeling cohere (#14)

* Update chat templates to use the new API (#15)

---------

Co-authored-by: ahmetustun <[email protected]>
Co-authored-by: Younes Belkada <[email protected]>
Co-authored-by: Matt <[email protected]>
LysandreJik pushed a commit to LysandreJik/transformers that referenced this issue Apr 10, 2024
@Rocketknight1
Update chat templates to use the new API (huggingface#15)
24a2227
itazap pushed a commit that referenced this issue May 14, 2024
@saurabhdash2512 @ahmetustun
@younesbelkada @Rocketknight1
Cohere Model Release (#29622)
a4b0d3d 
* Cohere Model Release (#1)

Cohere Model Release

* Remove unnecessary files and code (#2)

Some cleanup

* Delete cohere-model directory (#3)

* Make Fix (#5)

* Pr fixes (#6)

* fixes for pr

* pr fixes for the format

* pr fixes for the format

* src/transformers/models/auto/tokenization_auto.py

* Tokenizer test (#8)

* tokenizer test

* format fix

* Adding Docs and other minor changes (#7)

* Add modeling tests (#9)

* Smol Fix (#11)

* tokenization tests are fixed

* format fixes

* fix pr doc tests

* fix pr doc tests

* fix pr doc tests

* fix pr style check

* small changes in cohere.md

* FIX: Address final comments for transformers integration (#13)

* fix modeling final nits and add proper test file

* for now leave empty tests

* add integration test

* push new test

* fix modeling cohere (#14)

* Update chat templates to use the new API (#15)

---------

Co-authored-by: ahmetustun <[email protected]>
Co-authored-by: Younes Belkada <[email protected]>
Co-authored-by: Matt <[email protected]>
ArthurZucker pushed a commit that referenced this issue Sep 25, 2024
@qubvel
Merge pull request #15 from huggingface/embed-interpolation
554ea46 
Interpolate embeddings for 560 size and update integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukovnikov @thomwolf