Remove 2 failing ONNX conversion tests #22660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Apr 7, 2023
|
OK. But should we do something like removing CI regarding this? Currently failing tests pop up. |
|
The documentation is not available anymore as the PR was closed or merged. |
|
I think you can remove the tests as well. |
|
@sgugger Just to confirm, we want/could remove all things like
also cc @michaelbenayoun @fxmarty |
|
No we're not removing code, just the tests if they start failing. |
|
OK, glad I ask! |
ydshieh
commented
Apr 7, 2023
| @@ -267,7 +267,7 @@ class FeaturesManager: | |||
| onnx_config_cls="models.deberta_v2.DebertaV2OnnxConfig", | |||
| ), | |||
| "deit": supported_features_mapping( | |||
| "default", "image-classification", "masked-im", onnx_config_cls="models.deit.DeiTOnnxConfig" | |||
| "default", "image-classification", onnx_config_cls="models.deit.DeiTOnnxConfig" | |||
There was a problem hiding this comment.
we just need to remove the model architecture (task) that cause problem after #22212
ydshieh
changed the title
|
Ping @sgugger again to draw a bit of his attention. |
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
fix Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After ##22212, two tests start to fail.