Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in a parameter name for open llama model #23637

Merged
merged 6 commits into from
May 23, 2023
Merged

Fix typo in a parameter name for open llama model #23637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78c7194
Update modeling_open_llama.py
aaalexlit May 21, 2023
e977982
Update configuration_open_llama.py
aaalexlit May 21, 2023
e7ea522
Update configuration_open_llama.py
aaalexlit May 22, 2023
3ddd4c5
Update configuration_open_llama.py
aaalexlit May 22, 2023
2f616fb
Update configuration_open_llama.py
aaalexlit May 23, 2023
3373822
Update configuration_open_llama.py
aaalexlit May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/transformers/models/open_llama/configuration_open_llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def __init__(
bos_token_id=1,
eos_token_id=2,
tie_word_embeddings=False,
use_memorry_efficient_attention=True,
use_memory_efficient_attention=True,
hidden_dropout_prob=0.1,
attention_dropout_prob=0.1,
use_stable_embedding=True,
Expand All @@ -116,7 +116,9 @@ def __init__(
self.initializer_range = initializer_range
self.rms_norm_eps = rms_norm_eps
self.use_cache = use_cache
self.use_memorry_efficient_attention = use_memorry_efficient_attention
self.use_memory_efficient_attention = kwargs.pop(
"use_memorry_efficient_attention", use_memory_efficient_attention
)
self.hidden_dropout_prob = hidden_dropout_prob
self.attention_dropout_prob = attention_dropout_prob
self.use_stable_embedding = use_stable_embedding
Expand Down
6 changes: 3 additions & 3 deletions src/transformers/models/open_llama/modeling_open_llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
except ImportError:
xops = None
logger.warn(
"Xformers is not installed correctly. If you want to use memorry_efficient_attention to accelerate training use the following command to install Xformers\npip install xformers."
"Xformers is not installed correctly. If you want to use memory_efficient_attention to accelerate training use the following command to install Xformers\npip install xformers."
)


Expand Down Expand Up @@ -226,7 +226,7 @@ def forward(

past_key_value = (key_states, value_states) if use_cache else None

if self.config.use_memorry_efficient_attention and xops is not None and self.training:
if self.config.use_memory_efficient_attention and xops is not None and self.training:
attn_weights = None
query_states = query_states.transpose(1, 2)
key_states = key_states.transpose(1, 2)
Expand Down Expand Up @@ -564,7 +564,7 @@ def forward(
if self.embed_layer_norm:
inputs_embeds = self.embed_layer_norm(inputs_embeds)
# embed positions
if self.config.use_memorry_efficient_attention and self.training:
if self.config.use_memory_efficient_attention and self.training:
attention_mask = None
elif attention_mask is None:
attention_mask = torch.ones(
Expand Down