Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated perplexity.mdx to Korean #23850

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

HanNayeoniee
Copy link
Contributor

@HanNayeoniee HanNayeoniee commented May 29, 2023

What does this PR do?

Translated perplexity.mdx file of the documentation to Korean.
Added draft of model_summary.mdx file because it's referenced.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 29, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 👍 참고한 문서까지 꼼꼼하게 추가해주셨네요!
아래 리뷰 코멘트 남깁니다 😄

docs/source/ko/perplexity.mdx Outdated Show resolved Hide resolved
docs/source/ko/perplexity.mdx Outdated Show resolved Hide resolved
docs/source/ko/perplexity.mdx Outdated Show resolved Hide resolved
@sim-so
Copy link
Contributor

sim-so commented Jun 3, 2023

좋은 번역 감사합니다! 앞서 올려주신 수정 제안 이외에 추가 의견 없습니다!

@HanNayeoniee HanNayeoniee marked this pull request as ready for review June 7, 2023 23:14
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review!
Nice addition 😉

docs/source/ko/perplexity.mdx Outdated Show resolved Hide resolved
docs/source/ko/model_summary.mdx Outdated Show resolved Hide resolved
@HanNayeoniee
Copy link
Contributor Author

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating 🤗

@ArthurZucker ArthurZucker merged commit e16191a into huggingface:main Jul 3, 2023
@HanNayeoniee HanNayeoniee deleted the ko-ppl branch July 23, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants