Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error in Bark fine_generation_config #25386

Closed
wants to merge 1 commit into from

Conversation

manzonif
Copy link

@manzonif manzonif commented Aug 8, 2023

Fix validation error:
ValueError: do_sample is set to False. However, temperature is set to 0.5 -- this flag is only used in sample-based generation modes. Set do_sample=True or unset temperature to continue.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Fix validation error:
ValueError: `do_sample` is set to `False`. However, temperature is set to 0.5 -- this flag is only used in sample-based generation modes. Set `do_sample=True` or unset temperature to continue.
@sgugger
Copy link
Collaborator

sgugger commented Aug 8, 2023

cc @gante

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@gante
Copy link
Member

gante commented Aug 9, 2023

Hey @manzonif 👋

BARK has different parameterization needs in its fine submodel, @ylacombe is taking care of the appropriate changes.

Setting do_sample=True is not the solution, as no sampling is involved. I'm closing the PR as we are discussing solutions internally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants