[TokenizerFast] Fix setting prefix space in __init__
#25563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
commented
Aug 22, 2023
|
|
||
| if add_prefix_space: | ||
| pre_tok_state = pre_tok_state.replace(b'"add_prefix_space":false', b'"add_prefix_space": true') | ||
| decoder_state = pre_tok_state.replace(b'"add_prefix_space":false', b'"add_prefix_space": true') |
There was a problem hiding this comment.
There's a type here, adding a test and a hot fix. Works alright with add_prefix_space=False which is the default so no worries here
Suggested change
| decoder_state = pre_tok_state.replace(b'"add_prefix_space":false', b'"add_prefix_space": true') | |
| decoder_state = decoder_state.replace(b'"add_prefix_space":false', b'"add_prefix_space": true') |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…5563) * properly support Sequence of pretokenizers * actual fix * make sure the fix works. Tests are not working for sure! * hacky way * add TODO * update * add a todo
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…5563) * properly support Sequence of pretokenizers * actual fix * make sure the fix works. Tests are not working for sure! * hacky way * add TODO * update * add a todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #24846. For Sequence tokenizer, the previous solution was never doing anything.